Tbh whether I use spaces around em dashes depends more on the font than anything. Some fonts have em dashes that are so long that putting spaces around them would be ridiculous.